Opened 17 years ago

Closed 17 years ago

Last modified 11 years ago

#16 closed defect (fixed)

Move cursor and scroll during do/undo

Reported by: David Aspinall <da+pgrac@…> Owned by: Graham Dutton
Priority: major Milestone:
Component: 1:pg-eclipse Keywords:
Cc:

Description

Restore cursor movement behaviour.

Attachments (2)

mylyn-context.zip (2.3 KB) - added by Graham Dutton 17 years ago.
mylyn/context/zip
mylyn-context.2.zip (2.3 KB) - added by Graham Dutton 17 years ago.
mylyn/context/zip

Download all attachments as: .zip

Change History (8)

comment:1 Changed 17 years ago by David Aspinall <da+pgtrac@…>

To say something more:

  • goto should not move the cursor
  • undo/do should move cursor, if the cursor is "tracking" the processed point

It isn't clear exactly what "tracking" should mean, but PG Emacs has evolved a comfortable behaviour, as well as some preferences to alter it (which probably few users use).

comment:2 Changed 17 years ago by David Aspinall

Milestone: PG-Eclipse-1.0.6

comment:3 Changed 17 years ago by David Aspinall

Owner: changed from David Aspinall to Graham Dutton

Changed 17 years ago by Graham Dutton

Attachment: mylyn-context.zip added

mylyn/context/zip

comment:4 Changed 17 years ago by Graham Dutton

Status: newassigned

Use of a text selection at the end of any GotoAction? has helped. Location of the additional line of code will probably have to be moved to take into account cases where the actual locked area differs from the suggested position. TODO: pull out retrieval of selection location to match setting of selection location.

Changed 17 years ago by Graham Dutton

Attachment: mylyn-context.2.zip added

mylyn/context/zip

comment:5 Changed 17 years ago by Graham Dutton

Resolution: fixed
Status: assignedclosed

Seems to work OK now. had to refactor the gotoThread to allow a 'done' listener callback, which sets the cursor position to the locked / processed offset (as appropriate) on goto completion.

comment:6 Changed 11 years ago by David Aspinall

Milestone: PG-Eclipse-1.0.6

Milestone PG-Eclipse-1.0.6 deleted

Note: See TracTickets for help on using tickets.